upgrade github-changes to 2.0.2 (was 1.1.1) #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: we want to get on newer underscore and lodash because we keep getting security alerts for them
MaximeKjaer
approved these changes
Jun 1, 2021
There was a problem hiding this comment.
Looks fine, thank you! I took a look at github-changes, and even though it's a major version bump, it seems like we there are no breaking changes in that library that would affect us.
I wish there was a way to tell GitHub that security issues in devDependencies shouldn't generate alerts...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: we want to get on newer underscore and lodash because we keep getting security alerts for them
note that I have absolutely no idea what I'm doing. I'm running yarn commands I googled. I have no clue if this might actually be a bad idea for some reason
fwiw, note that
yarn installfailed for me until I downgraded to node 14, as per https://stackoverflow.com/a/67529863/86485